[16.0][IMP] dms_field: Add partner embedded DMS template #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should avoid using demo data on tests. |
victoralmau
force-pushed
the
16.0-imp-dms_field-issue-377
branch
2 times, most recently
from
be9b288 to
1b78a1d
Compare
I don't totally agree, but ok, it's already changed. |
CarlosRoca13
approved these changes
Nov 22, 2024
|
Ping @pedrobaeza |
pedrobaeza
requested changes
Nov 25, 2024
There was a problem hiding this comment.
We should avoid using demo data on tests.
I don't totally agree, but ok, it's already changed.
About this, the reasons are:
- Being self-contained: any change on data across versions/updates that affect the tests are not contained on the test file itself, and they are more difficult to be traced.
- Being reliable: if you depend on demo data, that demo data may be manually altered on the current DB, making the test to fail.
Thus, we must avoid it, the same as finally Odoo has done in its own tests.
In this module, I also see more dependencies to demo data (like dms.access_group_01_demo, dms.storage_demo, etc), so they must be removed.
victoralmau
force-pushed
the
16.0-imp-dms_field-issue-377
branch
from
1b78a1d to
0b6c950
Compare
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 1670f54. Thanks a lot for contributing to OCA. ❤️ |
victoralmau
added a commit
to Tecnativa/dms
that referenced
this pull request
Nov 29, 2024
We need to avoid applying a template except when testing functionality with dms_field* modules to avoid the error that a directory with the same name already exists (example: create partner). Related to OCA#378
victoralmau
added a commit
to Tecnativa/dms
that referenced
this pull request
Nov 29, 2024
We need to avoid applying a template except when testing functionality with dms_field* modules to avoid the error that a directory with the same name already exists (example: create partner). Related to OCA#378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add partner embedded DMS template
Fixes #377
Please @pedrobaeza and @CarlosRoca13 can you review it?
@Tecnativa